On Wed Jul 9 08:49:53 2025 +0000, Hans Leidekker wrote:
I've made many more assumptions like this. I was planning to address them after this code settles, or do you think we should do that now?
I think it's better to check and emit proper errors before making assumptions yes. I also don't want to block progress if you have more patches pending, but this is particularly noticeable.
I think changing the if into an assert would make it better, and explicit that the last 3 arguments are mandatory.