Re: [PATCH v24 0/8] MR3103: server: Create and use a desktop shared mapping for GetCursorPos.

[Jinoh Kang (＠iamahuman)]

Jinoh Kang (@iamahuman) commented about server/mapping.c:
> -
>
> +static int grow_session_mapping(void)
> +{
> - unsigned int capacity;
> - mem_size_t size;
> - int unix_fd;
> - void *tmp;
> -
> - capacity = session.shared->object_capacity * 3 / 2;
> - size = offsetof(session_shm_t, objects[capacity]);
> - size = (size + page_mask) & ~((mem_size_t)page_mask);
> -
> - unix_fd = get_unix_fd( session_mapping->fd );
> - if (!grow_file( unix_fd, size )) return -1;
> -
> - if ((tmp = mmap( NULL, size, PROT_READ | PROT_WRITE, MAP_SHARED, unix_fd, 0 )) == MAP_FAILED) return -1;

We're failing without setting error. This will make create_desktop server call fail with `STATUS_SUCCESS`.

```suggestion:-0+0
    if ((tmp = mmap( NULL, size, PROT_READ | PROT_WRITE, MAP_SHARED, unix_fd, 0 )) == MAP_FAILED)
    {
        file_set_error();
        return -1;
    }
```