Re: [PATCH v6 0/9] MR7667: powrprof.dll: Implement functions to enable SteamVR launch

[Alfred Agrell (＠Alcaro)]

Alfred Agrell (@Alcaro) commented about dlls/powrprof/powrprof.c:
> DWORD WINAPI PowerGetActiveScheme(HKEY UserRootPowerKey, GUID **polguid)
>  {
> - FIXME("(%p,%p) stub!\n", UserRootPowerKey, polguid);
> - return ERROR_CALL_NOT_IMPLEMENTED;
> - FIXME("should use registry\n");
> - /* Windows throws an access violation if **polguid is NULL,
> -
>   so I guess we will too. */
> - TRACE("*polguid %p, active_power_scheme %s\n",*polguid,

*polguid is some uninitialized stack garbage from the caller, and will soon be overwritten. Better remove the asterisk. Better trace that HKEY too.

Tracing global variables like that is rare; sounds useful, but nothing else in Wine does that. I don't know if it's a good or bad idea.