Re: [PATCH 0/4] MR4852: Add support from AudioPathConfig

[Rémi Bernon (＠rbernon)]

Rémi Bernon (@rbernon) commented about dlls/dmime/audiopath.c:
> -
>        TRACE("\tdwSize: %lu\n", port_config->params.dwSize);
> -
>        TRACE("\tdwValidParams: %lx\n", port_config->params.dwValidParams);
> -
>        if (port_config->params.dwValidParams & DMUS_PORTPARAMS_VOICES)
> -
>            TRACE("\tvoices: %lu\n", port_config->params.dwVoices);
> -
>        if (port_config->params.dwValidParams & DMUS_PORTPARAMS_CHANNELGROUPS)
> -
>            TRACE("\tchannel groups: %lu\n", port_config->params.dwChannelGroups);
> -
>        if (port_config->params.dwValidParams & DMUS_PORTPARAMS_AUDIOCHANNELS)
> -
>            TRACE("\taudio channels: %lu\n", port_config->params.dwAudioChannels);
> -
>        if (port_config->params.dwValidParams & DMUS_PORTPARAMS_SAMPLERATE)
> -
>            TRACE("\tsample rate: %lu\n", port_config->params.dwSampleRate);
> -
>        if (port_config->params.dwValidParams & DMUS_PORTPARAMS_EFFECTS)
> -
>            TRACE("\teffects: %lx\n", port_config->params.dwEffectFlags);
> -
>        if (port_config->params.dwValidParams & DMUS_PORTPARAMS_SHARE)
> -
>            TRACE("\tshare: %d\n", port_config->params.fShare);
> -
>        if (port_config->params.dwValidParams & DMUS_PORTPARAMS_FEATURES)
> -
>            TRACE("\tfeatures: %lx\n", port_config->params.dwFeatures);

Michael might say otherwise but outside of local changes for development, I don't think it's very useful to trace data that's not used. A simple FIXME would be enough for now.