On Tue Mar 26 04:38:03 2024 +0000, Francisco Casas wrote:
Well, as I mentioned in the other MR, I have a preference for having the structs that own other structs through pointers, as pointers themselves. For instance, if we put this struct in an array (as in the new version of that patch) without doing it through pointers, a reallocation will invalidate previous pointers to them. Granted, this doesn't happen right now, and probably will never happen for this struct, but I don't think there is any downside either? I can change it to a flat struct if you prefer.
Well, the downside is we have to do more malloc/free, mainly. I don't know that it's a strong downside, but it is the kind of thing I tend to avoid. I at least can't promise I won't convert it back to a flat struct at some point if we leave it like this.