Re: [PATCH v2 0/7] MR6220: mfplat: Implement MFCreateMediaBufferFromMediaType for video formats and test video processor with 2D buffers.

[Nikolay Sivov (＠nsivov)]

Nikolay Sivov (@nsivov) commented about dlls/mfplat/buffer.c:
> -
>    FIXME("Major type %s is not supported.\n", debugstr_guid(&major));
> - else if (IsEqualGUID(&major, &MFMediaType_Video)
> -
>        && SUCCEEDED(hr = IMFMediaType_GetGUID(media_type, &MF_MT_SUBTYPE, &subtype))
> -
>        && SUCCEEDED(hr = IMFMediaType_GetUINT64(media_type, &MF_MT_FRAME_SIZE, &frame_size))
> -
>        && mf_format_get_stride(&subtype, frame_size >> 32, &is_yuv))
> - {
> -
>    BOOL bottom_up = FALSE;
> -
>    UINT32 stride;
>
> - return E_NOTIMPL;
> -
>    if (!is_yuv && SUCCEEDED(IMFMediaType_GetUINT32(media_type, &MF_MT_DEFAULT_STRIDE, &stride)))
> -
>        bottom_up = (int)stride < 0;
> -
> -
>    if (SUCCEEDED(hr = create_2d_buffer(frame_size >> 32, (UINT32)frame_size, subtype.Data1, bottom_up, buffer)))
> -
>        return hr;
> - }

I think we should keep E_NOTIMPL for other major types, so that fixme is visible.