Jeffrey Smith (@whydoubt) commented about dlls/gdiplus/tests/customlinecap.c:
- ok(custom != NULL, "Custom line cap was not created\n");
- stat = GdipDeleteCustomLineCap(custom);
- expect(Ok, stat);
- custom = NULL;
- stat = GdipCreateCustomLineCap(path, NULL, LineCapFlat, 0.0, &custom);
- expect(Ok, stat);
- ok(custom != NULL, "Custom line cap was not created\n"); stat = GdipDeleteCustomLineCap(custom); expect(Ok, stat);
- /* it's strange but native returns NotImplemented on stroke == NULL */
- stat = GdipCreatePath(FillModeAlternate, &path3);
- expect(Ok, stat);
- stat = GdipAddPathRectangle(path, 5.0, 5.0, 10.0, 10.0);
- expect(Ok, stat);
1. You are creating `path3` and then never use it. 2. Assuming you did intend to use it, it would more consistent with the existing test to create it in the same section where the other paths are initialized. 3. You are no longer exercising the NotImplemented case. It still seems useful to have test covering that.