22 Apr
2025
22 Apr
'25
8:35 p.m.
On Tue Apr 22 20:08:09 2025 +0000, Pali Rohár wrote:
Ok, could you help me which commit and how should I modify it to make it acceptable?
A few suggestions, take them with a grain of salt: * Open a bug report at https://bugs.winehq.org/ that describes one specific broken program and add `Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=<bug-number>` to each commit that is necessary to fix that program. * Replace the FIXMEs in the last commit with a single `ERR` in the `default` case of the switch. * Move some of the commits to separate MRs. It looks like the first, second, and last commits could be applied independently, so they could be submitted separately instead of asking for an all-or-nothing approval on all six commits.