Re: [PATCH v3 0/3] MR1918: Draft: Implement HTMLDocument_get_body and HTMLDocument_get_all for document fragments

[Gabriel Ivăncescu (＠insn)]

Gabriel Ivăncescu (@insn) commented about dlls/mshtml/htmldoc.c:
>          return E_UNEXPECTED;
>      }
>  }
> - else if(This->node.nsnode) {
> - else {
>     nsAString nsnode_name;
> -
>    nsIDOMDocumentFragment *frag;
>
> -
>    nsAString_Init(&nsnode_name, L"BODY");
> -
>    nsIDOMDocumentFragment_QuerySelector((nsIDOMDocumentFragment*)This->node.nsnode,
> -
>                                                &nsnode_name, (nsIDOMElement**)&nsbody);
> -
>    nsIDOMNode_QueryInterface(This->node.nsnode, &IID_nsIDOMDocumentFragment, (void**)&frag);

Please check the return value here for success and only query it if it succeeds. Note that an assert() is not enough, it's totally possible for it to fail (e.g. for XML documents, which are not fragments but not HTML documents either).