Re: [PATCH 0/5] MR5972: winegstreamer: Respect video format padding for wg_transform input buffers.

[Elizabeth Figura (＠zfigura)]

Elizabeth Figura (@zfigura) commented about dlls/winegstreamer/wg_transform.c:
> +static inline BOOL intersect_rect(RECT *dst, const RECT *src1, const RECT *src2)
> +{
> - dst->left = max(src1->left, src2->left);
> - dst->top = max(src1->top, src2->top);
> - dst->right = min(src1->right, src2->right);
> - dst->bottom = min(src1->bottom, src2->bottom);
> - return !IsRectEmpty(dst);
>
> +}
> -
>
> +static void update_video_aperture(MFVideoInfo *input_info, MFVideoInfo *output_info)
> +{
> - RECT rect, input_rect, output_rect;
> -
> - init_mf_video_info_rect(input_info, &input_rect);
> - init_mf_video_info_rect(output_info, &output_rect);
> - intersect_rect(&rect, &input_rect, &output_rect);

Where does this come from? Unless I've missed something, there are no tests for mismatched content sizes (only mismatched frame sizes with the same content size).

If that's the case, and I'm not missing a test somewhere, can we please either add some tests, or stop pretending to handle mismatched content size, instead just erroring out with a FIXME?