Re: [PATCH v8 0/1] MR3959: uxtheme: Add ShouldSystemUseDarkMode.

[Zhiyi Zhang (＠zhiyi)]

Zhiyi Zhang (@zhiyi) commented about dlls/uxtheme/system.c:
> +/**********************************************************************
> -
> -
>  ShouldSystemUseDarkMode                           (UXTHEME.138)
> -
> -
> -
> - RETURNS
> -
> -
> Whether or not the system/app should use dark mode.
> - */
>
> +BOOL WINAPI ShouldSystemUseDarkMode(void)
> +{
> - DWORD system_uses_light_theme_size = sizeof(DWORD);
> - /* Persists between calls, in windows it might look up some internal table. */
> - static DWORD system_uses_light_theme = TRUE;
> -
> - /* We don't necessarily care that this might fail because it doesn't affect
> -
> * system_uses_light_theme if it does. 
> - */
> - RegGetValueA(HKEY_CURRENT_USER,

Please use RegGetValueW() instead so that we don't have to do ASCII/Unicode conversion every time this gets called.