On Thu Sep 1 12:07:39 2022 +0000, Matteo Bruni wrote:
This is my fault, see https://gitlab.winehq.org/wine/wine/-/merge_requests/697#note_7369 / https://gitlab.winehq.org/wine/wine/-/merge_requests/332#note_3151. I should have mentioned that I didn't expect a Wine test to check for that, just a manual look on the side (in fact I was picturing this as VirtualAlloc(), copy the source there, VirtualProtect(PAGE_READONLY), call D3D10CreateEffectFromMemory(), run on Windows and verify that it doesn't crash). I will probably have a go at it myself. I don't think that at this point we have a good reason to have the tests from this patch in Wine. Sorry for the extra work that I accidentally had you do.
FWIW I did the test I mentioned earlier and no surprises, everything works just fine.