28 Feb
2025
28 Feb
'25
4:40 p.m.
On Fri Feb 28 16:25:10 2025 +0000, Jinoh Kang wrote:
I'm fine with moving the ok. I'm asking for the ok condition to include `res == STATUS_INVALID_PARAMETER`, just like it has been before, instead of in the skip condition.
I am not sure if I understand you right. Before this patch `res == STATUS_INVALID_PARAMETER` was part of the ok and the if condition around the skip. After my patch the ok should never get reached with `res == STATUS_INVALID_PARAMETER`, so isn't checking for it superfluous?
I am happy with either way, should I add it again?