Re: [PATCH v3 0/8] MR4284: msvcrt: Add implementation and fixes to localize functions

[Piotr Caban (＠piotr)]

Piotr Caban (@piotr) commented about dlls/msvcrt/string.c:
>  pthreadlocinfo locinfo;
>  int c1, c2;
>
> - if(s1==NULL || s2==NULL)
> - if(!MSVCRT_CHECK_PMT(s1 && s2 && count <= 0x7fffffff))

Old versions of msvcrt.dll didn't have count <= INT_MAX check. The change may break some old applications. Is there any application that depends on that change?

Could you please fix the `count == 0` case while you're at it? The function should return early in such case without checking `s1` and `s2` parameters.