Re: [PATCH v15 0/3] MR5081: dmime: Read through a MIDI file

[Rémi Bernon (＠rbernon)]

Rémi Bernon (@rbernon) commented about dlls/dmime/midi.c:
> HRESULT midi_parser_next_track(struct midi_parser *parser, IDirectMusicTrack **out_track, MUSIC_TIME *out_length)
>  {
> - TRACE("(%p, %p, %p): stub\n", parser, out_track, out_length);
> - WORD i = 0;
> - TRACE("(%p, %p): stub\n", parser, out_length);
> - while (TRUE)
> - {
> -
>    HRESULT hr;
> -
>    BYTE magic[4] = {0}, last_status = 0;
> -
>    DWORD length_be;
> -
>    ULONG length;
> -
>    ULONG read = 0;
> -
> -
>    TRACE("Start parsing track %u\n", i);
> -
>    if ((hr = IStream_Read(parser->stream, magic, sizeof(magic), &read)) != S_OK) return hr;
> -
>    if (read == 0) break;

That check seems unnecessary as magic is zero-initialized? Or maybe better leave it uninitialized and do:

```suggestion:-0+0
        if (read < sizeof(magic)) break;
```