Re: [PATCH v2 0/1] MR2498: msado15: Implement _Recordset Find

[Zebediah Figura (＠zfigura)]

On Fri May 19 08:22:28 2023 +0000, Alistair Leslie-Hughes wrote:
> If we want to extend the tests to use real data, we only want to create
> the database one.  I would expect the next patch _Filter to want to use
> the same database.

Why only once? Why not create it separately for each test, to avoid the possibility of one test affecting another?

And if we do want to create it only once, this doesn't seem like an idiomatic way to do it. I'd probably still return this value from setup_database(), and then in the main function do something like

if (setup_database())
{
    test_recordset_find();
    test_something_else();
    cleanup_database();
}