Re: [PATCH v4 0/4] MR450: vkd3d-shader/ir: Flatten structured control flow instructions.

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/ir.c:
>      case VKD3DSIH_SWITCH:
>          vsir_validate_dst_count(ctx, instruction, 0);
>          vsir_validate_src_count(ctx, instruction, 1);
> -
>        /* New monolithic switch variant. */
> -
>        if (instruction->declaration.switch_.case_count)
> -
>            break;

It seems the new `switch` should be considered an entirely different instruction, given how different it is. It could be renamed to `branch_switch`.

Also, comments with the word "new" in them are likely to eventually become false, or at least misleading.