On Thu Apr 4 00:34:41 2024 +0000, Elizabeth Figura wrote:
I don't hate 2/5, but I'm not sure I really want to add more code to work around this, instead of just preferring the real MPEG-1 splitter. We have all the infrastructure in place to output compressed samples like on Windows, we just need to hook it up here. That would mean adding the relevant formats to autoplug-continue, and then lowering the priority of the decodebin parser so that it's below that of the MPEG splitter, probably to MERIT_NORMAL - 1. That also puts it below the AVI splitter, and in order to avoid regressions from unknown formats, that means we should port the AVI splitter over to the same scheme the MPEG splitter uses, i.e. an equivalent of 5c24b7e56. Fortunately I think that should all be pretty easy.
(2/5 is just adding a test, I'll assume you mean 1/5.)
Yeah, I'm not sure about that part either. I'm not sure about any of this, other than what BURIKO needs, and I have no idea about _why_ any of that.
As mentioned in bugzilla, using the MPEG splitter and decoders may have a performance impact, even in applications that don't care about compressed MPEG; that's why I chose this approach. And, as you said, changing filter priorities yields a regression risk.
But if you feel that the improved do-it-right-ness outweighs said drawbacks, then so be it. Please confirm which way you want it.