Re: [PATCH 0/6] MR6360: d3dx9: Beginning of pixel format handling changes.

[Matteo Bruni (＠Mystral)]

Matteo Bruni (@Mystral) commented about dlls/d3dx9_36/tests/surface.c:
> -
>    0xffffffff, 0x00000000, 0xffffffff, 0x00000000, 0xffffffff, 0x00000000, 0xffffffff, 0x00000000,
> -
>    0xffffffff, 0x00000000, 0xffffffff, 0x00000000, 0xffffffff, 0x00000000, 0xffffffff, 0x00000000,
> - };
> - /* 4x4 block of red pixels with an alpha value of 0. */
> - static const uint8_t dxt_block[] =
> - {
> -
>    0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0xf8,0x00,0xf8,0xaa,0xaa,0xaa,0xaa,
> - };
> - static const RECT src_rect = { 0, 0, 4, 4 };
> - IDirect3DSurface9 *decomp_surf;
> - D3DLOCKED_RECT lock_rect;
> - uint32_t i, x, y;
> - HRESULT hr;
> -
> - hr = IDirect3DDevice9_CreateOffscreenPlainSurface(device, 4, 4, D3DFMT_A8R8G8B8, D3DPOOL_SYSTEMMEM, &decomp_surf, NULL);
> - if (FAILED(hr))

I think we don't need to handle the failure case here (i.e. so many existing tests would fail if we can't create that kind of surface.)