Re: [PATCH 0/1] MR8063: shell32: Create an internal IDropSource in SHDoDragDrop if it wasn't passed by the caller

[Alfred Agrell (＠Alcaro)]

Alfred Agrell (@Alcaro) commented about dlls/shell32/shellord.c:
> -
>
> +static HRESULT WINAPI IDummyDropSource_QueryInterface(IDropSource *iface, REFIID riid, void **ppvObj)
> +{
> - IDummySource *This = impl_from_IDropSource(iface);
> - TRACE("(%p)->(%s, %p)\n", This, debugstr_guid(riid), ppvObj);
> -
> - *ppvObj = NULL;
> -
> - if(IsEqualIID(riid, &IID_IDropSource))
> - {
> -
>    *ppvObj = &This->IDropSource_iface;
> -
>    TRACE("-- Interface: (%p)->(%p)\n",ppvObj,*ppvObj);
> -
>    return S_OK;
> - }
> -
> - TRACE("-- Interface: E_NOINTERFACE\n");

Isn't E_NOINTERFACE usually a WARN? And I don't think that's the usual QueryInterface trace formatting, but I'm not sure how consistent Wine is.