From: Gabriel Ivăncescu gabrielopcode@gmail.com
Signed-off-by: Gabriel Ivăncescu gabrielopcode@gmail.com --- dlls/mshtml/htmlattr.c | 7 +++++-- dlls/mshtml/tests/dom.c | 9 +++++++++ 2 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/dlls/mshtml/htmlattr.c b/dlls/mshtml/htmlattr.c index c64ac5bad14..d3577b34096 100644 --- a/dlls/mshtml/htmlattr.c +++ b/dlls/mshtml/htmlattr.c @@ -324,8 +324,11 @@ static HRESULT WINAPI HTMLDOMAttribute2_appendChild(IHTMLDOMAttribute2 *iface, I static HRESULT WINAPI HTMLDOMAttribute2_hasChildNodes(IHTMLDOMAttribute2 *iface, VARIANT_BOOL *fChildren) { HTMLDOMAttribute *This = impl_from_IHTMLDOMAttribute2(iface); - FIXME("(%p)->(%p)\n", This, fChildren); - return E_NOTIMPL; + + TRACE("(%p)->(%p)\n", This, fChildren); + + *fChildren = VARIANT_FALSE; + return S_OK; }
static HRESULT WINAPI HTMLDOMAttribute2_cloneNode(IHTMLDOMAttribute2 *iface, VARIANT_BOOL fDeep, diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c index 5b043ff4b93..a611ff7584a 100644 --- a/dlls/mshtml/tests/dom.c +++ b/dlls/mshtml/tests/dom.c @@ -9952,6 +9952,7 @@ static void test_attr_node(IHTMLDOMAttribute *test_attr, IHTMLDocument2 *doc) IHTMLDocument2 *doc_node; IHTMLWindow2 *window; IHTMLElement *elem; + VARIANT_BOOL vbool; VARIANT v, v_clone; IDispatch *disp; HRESULT hres; @@ -10003,6 +10004,10 @@ static void test_attr_node(IHTMLDOMAttribute *test_attr, IHTMLDocument2 *doc) VariantClear(&v_clone); VariantClear(&v);
+ hres = IHTMLDOMAttribute2_hasChildNodes(attr, &vbool); + ok(hres == S_OK, "hasChildNodes failed: %08lx\n", hres); + ok(vbool == VARIANT_FALSE, "hasChildNodes returned %d\n", vbool); + bstr = SysAllocString(L"div"); hres = IHTMLDocument2_createElement(doc, bstr, &elem); ok(hres == S_OK, "createElement failed: %08lx\n", hres); @@ -10020,6 +10025,10 @@ static void test_attr_node(IHTMLDOMAttribute *test_attr, IHTMLDocument2 *doc) ok(hres == S_OK, "insertBefore failed: %08lx\n", hres); ok(!node, "inserted node != NULL\n");
+ hres = IHTMLDOMAttribute2_hasChildNodes(attr, &vbool); + ok(hres == S_OK, "hasChildNodes failed: %08lx\n", hres); + ok(vbool == VARIANT_FALSE, "hasChildNodes returned %d\n", vbool); + IHTMLDOMNode_Release(elem_node); IHTMLDOMAttribute2_Release(attr); }