On Sat May 3 10:04:45 2025 +0000, Pali Rohár wrote:
Those examples are good starting point for any debugging. Without understanding what is going wrong in small examples, it is impossible at least for me to fix the actually crashing application. For me the first thing is to figure out why the wine's behavior deviates from the original Windows behavior. And this is one example which is aligning wine's behavior to Windows one, and make one part of the CHGDIR application to not crash.
All changes have a cost, in reviewer's time, in code churn, in possible regressions. The cost needs to be balanced by an actual benefit, i.e. it should improve something for a real user.
That's doubly true for very old 16-bit code. If no user has run into these issues for all these years, and with 16-bit usefulness dwindling, it seems unlikely that making changes there would have any benefit. Simply "aligning behavior with Windows" is not considered a benefit in itself, particularly in such old code.
If you have a real application that's crashing, please file a bug about it, and then we can discuss how to fix it, ideally with a minimal amount of changes.