Re: [PATCH 0/1] MR2498: msado15: Implement _Recordset Find

[Zebediah Figura (＠zfigura)]

Zebediah Figura (@zfigura) commented about dlls/msado15/tests/msado15.c:
>  hr = _Recordset_Open( recordset, missing, missing, adOpenStatic, adLockBatchOptimistic, adCmdUnspecified );
>  ok( hr == MAKE_ADO_HRESULT( adErrObjectOpen ), "got %08lx\n", hr );
>
> - V_VT( &index ) = VT_EMPTY;
> - crit = SysAllocString(L"field = 1 OR field = 2");
> - hr = _Recordset_Find(recordset, crit, 0, adSearchForward, index);
> - ok( hr == MAKE_ADO_HRESULT( adErrDataConversion ), "got %08lx\n", hr );
> - SysFreeString(crit);
> -
> - crit = SysAllocString(L"");
> - hr = _Recordset_Find(recordset, crit, 0, adSearchForward, index);
> - ok( hr == MAKE_ADO_HRESULT( adErrDataConversion ), "got %08lx\n", hr );
> - SysFreeString(crit);
> -

The lack of any tests for successful matches, or successful non-matches, strikes me as a bit concerning.