On Wed Mar 19 15:23:17 2025 +0000, Zhiyi Zhang wrote:
if we need to separately specify fill and stroke colors, then maybe button-pushbutton-hot-fill and button-pushbutton-hot-stroke
Yeah coming up with a sensible naming scheme is indeed a problem.
Is there any documentation from Microsoft's side about the terms to use? Going by control state as you suggest has some appeal, but doesn't match up well to the registry entries and .rc values. Without knowing the uxtheme/comctl implementations I didn't see those terms anywhere.
E.g. the pre-theme colors make a difference between light and dark shadows, which can make a control appear either raised (button) or depressed (textbox, pressed buttoon). The light theme doesn't make a difference in the SVGs - is this a limitation of the .msstyle interface itself or simply an artistic choice on your end?
We don't need to come up with a perfect scheme right away. While working on the patches that I have so far I came across a few cases of "this seems, wrong, shouldn't it be color XYZ" and deliberately ignored them for now to keep my patches a functional no-op. Before adding any more themes we're certainly going to clean up a few things.