Re: [PATCH 0/2] MR8920: cmd: Fix some TYPE command behavior (one more try).

[eric pouech (＠epo)]

eric pouech (@epo) commented about programs/cmd/builtins.c:
> - }
> - hOut = GetStdHandle(STD_OUTPUT_HANDLE);
> - if (hOut == INVALID_HANDLE_VALUE) {
> -
>  WCMD_print_error ();
> -
>  WCMD_output_stderr(WCMD_LoadMessage(WCMD_READFAIL), thisArg);
> -
>  CloseHandle(hIn);
> -
>  return errorlevel = ERROR_INVALID_FUNCTION;
> - }
> -
> - if (writeHeaders) {
> -
>  WCMD_output_stderr(L"\n%1\n\n\n", thisArg);
> - }
> -
> - if (GetFileType(hIn) == FILE_TYPE_CHAR || GetFileType(hOut) == FILE_TYPE_CHAR) {
> -
>  /* text mode */
> -
>  while (WCMD_ReadFile(hIn, buffer, ARRAY_SIZE(buffer) - 1, &count)) {

shouldn't we just do a ManualCopy(..., TRUE) here instead?