On Tue Apr 4 13:23:50 2023 +0000, Henri Verbeet wrote:
I guess it depends a lot on what you consider fragile or clumsy.
Well, to make it a bit more concrete, at least 3 people originally missed this issue in commit bb2fa97c33fd1591097741b809854763c0623697, and it took me a bit more time than I would've liked to review this MR. Arguably a good chunk of that is down to my shortcomings as a reviewer, but perhaps we could try to cater to those?
Sure, and for the sake of completeness I also take the share of responsibility due to my inability to invalidate assumptions across patch rewritings, but I am not sure of what you would consider better. Does any of the two alternatives I wrote above work better for you? Or would you propose something else?