On Thu Mar 9 09:30:49 2023 +0000, Sven Baars wrote:
That's very strange since I didn't modify these lines of code, so I'd expect the warning to also be there before any of my patches. I also don't see the warning locally. I do get rid of this code later in my patch series. Fixing it earlier will create a mess since attr is currently used everywhere, but I guess it could be done. Since I don't see the warning it may be difficult to do without introducing it again in intermediate commits.
I pushed 4 extra commits that move attr to open_key() and create_key() before doing anything else.