Re: [PATCH 1/1] include: Fix boolean return value definition in IIterator<T> methods.

[Paul Gofman]

On 12/22/23 01:37, Dmitry Timoshkov wrote:
> Paul Gofman  wrote:
> > diff --git a/dlls/dinput/tests/hotplug.c b/dlls/dinput/tests/hotplug.c
> > index 7187cf7dc38..5b9455d1819 100644
> > --- a/dlls/dinput/tests/hotplug.c
> > +++ b/dlls/dinput/tests/hotplug.c
> > @@ -977,11 +977,11 @@ static void test_windows_gaming_input(void)
> >       HANDLE hwnd, thread, stop_event;
> >       IInspectable *tmp_inspectable;
> >       HDEVNOTIFY devnotify;
> > - boolean boolret;
> >  HSTRING str;
> >  UINT32 size;
> >  HRESULT hr;
> >  DWORD res;
> > - BOOL ret;
> >  MSG msg;
>
> It should be possible to use Windows type BOOLEAN for the same purpose.

That's true, although I saw some existing WinRT dlls already using 
boolean and it is used this way in Win headers and samples, so probably 
no particular reason to stick to winnt definitions?
> Also
> avoiding to rename a variable would reduce the diff.

Well, I have touch the line anyway, I hope that more explicit naming 
won't hurt.