Re: [PATCH v4 0/3] MR692: vkd3d-shader/fx: Add "child-effect" compilation option.

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/fx.c:
> +static const char * get_fx_4_type_name(const struct hlsl_type *type)
>  {
> - struct vkd3d_bytecode_buffer *buffer = &fx->unstructured;
> - uint32_t name_offset, offset, size, stride, numeric_desc;
> - uint32_t elements_count = 0;
> - const char *name;
> - static const uint32_t variable_type[] =
> - static const char * const object_type_names[] =
> {
> -
>    [HLSL_CLASS_SCALAR] = 1,
> -
>    [HLSL_CLASS_VECTOR] = 1,
> -
>    [HLSL_CLASS_MATRIX] = 1,
> -
>    [HLSL_CLASS_OBJECT] = 2,
> -
>    [HLSL_CLASS_STRUCT] = 3,
> -
>    [HLSL_TYPE_RENDERTARGETVIEW] = "RenderTargetView",
> -
>    [HLSL_TYPE_DEPTHSTENCILVIEW] = "DepthStencilView",

Mmh, is it intended that `PixelShader` and `VertexShader` are missing here? Below you seem to dereference them.