On Tue Mar 4 09:33:54 2025 +0000, Konstantin Demin wrote:
I don't want to hardcode toolchain-based tool names because Wine is buildable with Clang or GCC and if both are present in environment this may lead to unforeseen consequences. Both winebuild and winegcc have similar tool/binary lookup functions so I'd write unified implementation. Last patch is merely quirk so it may disable LTO for more sources than is actually required.
I'm pretty sure it already uses heuristics and such to detect build system in use, so "hardcoding" is fine as long as it has fallbacks.
Having an option like --enable-lto and requiring env vars for it to work is not good design IMO.