[PATCH v8 2/6] propsys/tests: Test PropVariantToBSTR.

[Ziqing Hui]

From: Ziqing Hui

---
 dlls/propsys/tests/propsys.c | 110 ++++++++++++++++++++++++++++++++++-
 1 file changed, 108 insertions(+), 2 deletions(-)

diff --git a/dlls/propsys/tests/propsys.c b/dlls/propsys/tests/propsys.c
index 5d8f549a44d..134702c8b86 100644
--- a/dlls/propsys/tests/propsys.c
+++ b/dlls/propsys/tests/propsys.c
@@ -1621,6 +1621,112 @@ static void test_PropVariantToString(void)
     memset(bufferW, 0, sizeof(bufferW));
 }

+#define check_PropVariantToBSTR(type, member, value, expect_str)    \
+do                                                                  \
+{                                                                   \
+    PROPVARIANT check_propvar_ = {.vt = (type), .member = (value)}; \
+    HRESULT check_hr_;                                              \
+    BSTR check_bstr_;                                               \
+                                                                    \
+    check_hr_ = PropVariantToBSTR(&check_propvar_, &check_bstr_);   \
+    ok_(__FILE__, __LINE__)(check_hr_ == S_OK,                      \
+            "PropVariantToBSTR returned %#lx.\n", check_hr_);       \
+                                                                    \
+    if (check_hr_ == S_OK)                                          \
+    {                                                               \
+        ok_(__FILE__, __LINE__)(!wcscmp(check_bstr_, (expect_str)), \
+                "Unexpected bstr %s.\n", debugstr_w(check_bstr_));  \
+        SysFreeString(check_bstr_);                                 \
+    }                                                               \
+} while (0)
+
+static void test_PropVariantToBSTR(void)
+{
+    unsigned char test_bytes[] = {1, 20, 30, 4};
+    WCHAR test_bstr[] = {'a', 0, 'b', 0, 'c'};
+    PROPVARIANT propvar;
+    UINT length;
+    HRESULT hr;
+    BSTR bstr;
+
+    if (0) /* Crashes. */
+    {
+        hr = PropVariantToBSTR(&propvar, NULL);
+        hr = PropVariantToBSTR(NULL, &bstr);
+    }
+
+    todo_wine
+    {
+    check_PropVariantToBSTR(VT_I1,     cVal,           -123,                 L"-123");
+    check_PropVariantToBSTR(VT_I2,     iVal,           -456,                 L"-456");
+    check_PropVariantToBSTR(VT_I4,     lVal,           -789,                 L"-789");
+    check_PropVariantToBSTR(VT_I8,     hVal.QuadPart,  -101112,              L"-101112");
+    check_PropVariantToBSTR(VT_UI1,    bVal,           0xcd,                 L"205");
+    check_PropVariantToBSTR(VT_UI2,    uiVal,          0xdead,               L"57005");
+    check_PropVariantToBSTR(VT_UI4,    ulVal,          0xdeadbeef,           L"3735928559");
+    check_PropVariantToBSTR(VT_UI8,    uhVal.QuadPart, 0xdeadbeefdeadbeef,   L"16045690984833335023");
+    check_PropVariantToBSTR(VT_BOOL,   boolVal,        TRUE,                 L"1");
+    check_PropVariantToBSTR(VT_R4,     fltVal,         0.123f,               L"0.123000003397464752");
+    check_PropVariantToBSTR(VT_R8,     dblVal,         0.456,                L"0.456000000238418579");
+    check_PropVariantToBSTR(VT_CLSID,  puuid,          (CLSID *)&dummy_guid, dummy_guid_str);
+    check_PropVariantToBSTR(VT_LPSTR,  pszVal,         (char *)topic,        topicW);
+    check_PropVariantToBSTR(VT_LPWSTR, pwszVal,        (WCHAR *)topicW,      topicW);
+    }
+
+    PropVariantInit(&propvar);
+    propvar.vt = VT_FILETIME;
+    propvar.filetime.dwLowDateTime = 0xdead;
+    propvar.filetime.dwHighDateTime = 0xbeef;
+    hr = PropVariantToBSTR(&propvar, &bstr);
+    todo_wine
+    ok(hr == S_OK, "PropVariantToBSTR returned %#lx.\n", hr);
+    if (hr == S_OK)
+    {
+    ok(!wcscmp(bstr, L"1601/08/31:23:29:30.651"), "Unexpected bstr %s.\n", debugstr_w(bstr));
+    SysFreeString(bstr);
+    }
+
+    PropVariantInit(&propvar);
+    propvar.vt = VT_DATE;
+    propvar.date = 123.123f;
+    hr = PropVariantToBSTR(&propvar, &bstr);
+    todo_wine
+    ok(hr == S_OK, "PropVariantToBSTR returned %#lx.\n", hr);
+    if (hr == S_OK)
+    {
+    ok(!wcscmp(bstr, L"1900/05/02:02:57:07.000"), "Unexpected bstr %s.\n", debugstr_w(bstr));
+    SysFreeString(bstr);
+    }
+
+    PropVariantInit(&propvar);
+    propvar.vt = VT_VECTOR | VT_I1;
+    propvar.caub.cElems = ARRAY_SIZE(test_bytes);
+    propvar.caub.pElems = test_bytes;
+    hr = PropVariantToBSTR(&propvar, &bstr);
+    todo_wine
+    ok(hr == S_OK, "PropVariantToBSTR returned %#lx.\n", hr);
+    if (hr == S_OK)
+    {
+    ok(!wcscmp(bstr, L"1; 20; 30; 4"), "Unexpected bstr %s.\n", debugstr_w(bstr));
+    SysFreeString(bstr);
+    }
+
+    PropVariantInit(&propvar);
+    propvar.vt = VT_BSTR;
+    propvar.bstrVal = SysAllocStringLen(test_bstr, ARRAY_SIZE(test_bstr));
+    hr = PropVariantToBSTR(&propvar, &bstr);
+    todo_wine
+    ok(hr == S_OK, "PropVariantToBSTR returned %#lx.\n", hr);
+    if (hr == S_OK)
+    {
+    length = SysStringLen(bstr);
+    ok(length == wcslen(test_bstr), "Unexpected length %u.\n", length);
+    ok(!wcscmp(bstr, test_bstr), "Unexpected bstr %s.", debugstr_wn(bstr, ARRAY_SIZE(test_bstr)));
+    SysFreeString(bstr);
+    }
+    PropVariantClear(&propvar);
+}
+
 static void test_PropVariantToBuffer(void)
 {
     PROPVARIANT propvar;
@@ -1630,7 +1736,7 @@ static void test_PropVariantToBuffer(void)
     SAFEARRAY *sa;
     SAFEARRAYBOUND sabound;
     void *pdata;
-    UINT8 buffer[256];
+    UINT8 buffer[256] = {0};

hr = InitPropVariantFromBuffer(data, 10, &propvar);
     ok(hr == S_OK, "InitPropVariantFromBuffer failed 0x%08lx.\n", hr);
@@ -2365,7 +2471,6 @@ static void test_VariantToString(void)
             "Unexpected V_"#type"(&var) "format".\n", (propvar).member);                             \
 } while (0)

-
 static void test_VariantToPropVariant(void)
 {
     PROPVARIANT propvar;
@@ -2549,6 +2654,7 @@ START_TEST(propsys)
     test_PropVariantToStringWithDefault();
     test_PropVariantToDouble();
     test_PropVariantToString();
+    test_PropVariantToBSTR();
     test_PropVariantToBuffer();
     test_inmemorystore();
     test_persistserialized();