On Thu Feb 16 03:52:34 2023 +0000, Alex Henrie wrote:
Would you find `nt_ppd = { 0 }` more or less clear than `nt_ppd = { .Buffer = NULL }`? Yet another option is `nt_ppd = {}`, which is accepted by both GCC and MSVC and is being standardized in C23. Anyhow, I'm just putting ideas out there. If you like `nt_ppd = { .Buffer = NULL }` best then we'll go with that.
In cases like this, when it's clearly subjective, it's safe to assume that the reviewer will have considered the alternatives themselves and picked the one that they prefer, so unnecessarily prelonging the discussion isn't very useful and just wastes everybody's time.
For the record, I went with the designated initializer because the element we really care about is .Buffer. If however your initial commit had used either of the two alternatives I would have approved that.