Re: [PATCH v5 0/5] MR8654: windows.devices.bluetooth: Add stubs for BluetoothLEAdvertisementWatcher

[Rémi Bernon (＠rbernon)]

Rémi Bernon (@rbernon) commented about dlls/windows.devices.bluetooth/tests/bluetooth.c:
> - trace( "address: %I64X (%s)\n", addr, debugstr_bluetooth_addr( addr ) );
> -
> - hr = IBluetoothLEAdvertisementReceivedEventArgs_get_AdvertisementType( event, &adv_type );
> - todo_wine ok( hr == S_OK, "got hr %#lx.\n", hr );
> - todo_wine ok( adv_type <= BluetoothLEAdvertisementType_Extended, "got adv_type %d\n", adv_type );
> - trace( "advertisement type: %d\n", adv_type );
> -
> - hr = IBluetoothLEAdvertisementReceivedEventArgs_get_Timestamp( event, (DateTime *)&timestamp );
> - todo_wine ok( hr == S_OK, "got hr %#lx.\n", hr );
> - success = FileTimeToSystemTime( &timestamp, &st );
> - ok( success, "FileTimeToSystemTime failed: %#lx.\n", GetLastError() );
> - success = SystemTimeToTzSpecificLocalTime( NULL, &st, &st );
> - ok( success, "SystemTimeToTzSpecificLocalTime failed: %#lx.\n", GetLastError() );
> - buf[0] = 0;
> - GetTimeFormatEx( NULL, TIME_FORCE24HOURFORMAT, &st, NULL, buf, ARRAY_SIZE( buf ) );
> - trace("timestamp: %s\n", debugstr_w( buf ));

If we're not checking anything I'm not sure all these traces are useful to keep in the tests. They may be interesting for development but they will also potentially increase the test output unnecessarily, which is limited in size and it will fail the tests when the limit is reached.