[PATCH 1/2] msvcrt/tests: Add tests for strcoll/wcscoll.

[Daniel Lehman]

From: Daniel Lehman

---
 dlls/msvcrt/tests/string.c | 84 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 84 insertions(+)

diff --git a/dlls/msvcrt/tests/string.c b/dlls/msvcrt/tests/string.c
index a14e95704f3..24902d96f27 100644
--- a/dlls/msvcrt/tests/string.c
+++ b/dlls/msvcrt/tests/string.c
@@ -4227,6 +4227,89 @@ static void test__tcsncoll(void)
     }
 }

+static void test__tcscoll(void)
+{
+    struct test {
+        const char *locale;
+        const char *str1;
+        const char *str2;
+        int exp;
+        BOOL todo;
+    };
+    static const struct test tests[] = {
+        { "English", "ABCD", "ABCD",  0 },
+        { "English", "ABC",  "ABCD", -1 },
+        { "English", "ABCD",  "ABC",  1 },
+        { "English", "ABCe", "ABCf", -1 },
+        { "English", "abcd", "ABCD", -1 },
+        { "English", "AB D", "AB-D",  1, TRUE },
+        { "English", "AB D", "AB'D",  1, TRUE },
+
+        { "C",       "ABCD", "ABCD",  0 },
+        { "C",       "ABC",  "ABCD", -1 },
+        { "C",       "ABCD",  "ABC",  1 },
+        { "C",       "ABCe", "ABCf", -1 },
+        { "C",       "abcd", "ABCD",  1 },
+        { "C",       "AB D", "AB-D", -1 },
+        { "C",       "AB D", "AB'D", -1 },
+    };
+    WCHAR str1W[16];
+    WCHAR str2W[16];
+    char str1[16];
+    char str2[16];
+    size_t len;
+    int i, ret;
+
+    for (i = 0; i < ARRAY_SIZE(tests); i++)
+    {
+        if (!setlocale(LC_ALL, tests[i].locale))
+        {
+            win_skip("%s locale _tcsncoll tests\n", tests[i].locale);
+            for (; i+1 < ARRAY_SIZE(tests); i++)
+                if (strcmp(tests[i].locale, tests[i+1].locale)) break;
+            continue;
+        }
+
+        memset(str1, 0xee, sizeof(str1));
+        strcpy(str1, tests[i].str1);
+
+        memset(str2, 0xff, sizeof(str2));
+        strcpy(str2, tests[i].str2);
+
+        ret = strcoll(str1, str2);
+        if (!tests[i].exp)
+            ok(!ret, "expected 0, got %d for %s, %s for locale %s\n",
+               ret, str1, str2, tests[i].locale);
+        else if (tests[i].exp < 0)
+            ok(ret < 0, "expected < 0, got %d for %s, %s for locale %s\n",
+               ret, str1, str2, tests[i].locale);
+        else
+            todo_wine_if(tests[i].todo)
+            ok(ret > 0, "expected > 0, got %d for %s, %s for locale %s\n",
+               ret, str1, str2, tests[i].locale);
+
+        memset(str1W, 0xee, sizeof(str1W));
+        len = mbstowcs(str1W, str1, ARRAY_SIZE(str1W));
+        str1W[len] = 0;
+
+        memset(str2W, 0xff, sizeof(str2W));
+        len = mbstowcs(str2W, str2, ARRAY_SIZE(str2W));
+        str2W[len] = 0;
+
+        ret = wcscoll(str1W, str2W);
+        if (!tests[i].exp)
+            ok(!ret, "expected 0, got %d for %s, %s for locale %s\n",
+               ret, str1, str2, tests[i].locale);
+        else if (tests[i].exp < 0)
+            ok(ret < 0, "expected < 0, got %d for %s, %s for locale %s\n",
+               ret, str1, str2, tests[i].locale);
+        else
+            todo_wine_if(tests[i].todo)
+            ok(ret > 0, "expected > 0, got %d for %s, %s for locale %s\n",
+               ret, str1, str2, tests[i].locale);
+    }
+}
+
 static void test__tcsnicoll(void)
 {
     struct test {
@@ -4854,6 +4937,7 @@ START_TEST(string)
     test__memicmp_l();
     test__strupr();
     test__tcsncoll();
+    test__tcscoll();
     test__tcsnicoll();
     test___strncnt();
     test_C_locale();