Re: [PATCH 0/3] MR3737: winegstreamer: Implement wg_muxer.

[Rémi Bernon (＠rbernon)]

Rémi Bernon (@rbernon) commented about dlls/winegstreamer/wg_muxer.c:
> -
> - pthread_mutex_t mutex;
> - pthread_cond_t cond;
>
> +};
> -
>
> +static struct wg_muxer *get_muxer(wg_muxer_t muxer)
> +{
> - return (struct wg_muxer *)(ULONG_PTR)muxer;
>
> +}
> -
>
> +static void muxer_free_buffer(struct wg_muxer *muxer)
> +{
> - gst_buffer_unmap(muxer->buffer, &muxer->map_info);
> - gst_buffer_unref(muxer->buffer);
> - muxer->buffer = NULL;
>
> +}

Same for this helper. Also I don't know how the buffer is used, but I believe it's a bad GStreamer practice to keep the buffers mapped. Ideally you'd only map it / unmap shortly when needed.