Re: [PATCH v6 0/11] MR317: vkd3d-shader: Begin validating the generated IR.

[Francisco Casas (＠fcasas)]

Francisco Casas (@fcasas) commented about libs/vkd3d-shader/ir.c:
>          /* fall through */
>      case VKD3DSIH_DCL_INPUT_PS:
>      case VKD3DSIH_DCL_OUTPUT:
> -
>        keep = shader_dst_param_io_normalise(&ins->declaration.dst, true, normaliser);
> -
>        if (!shader_dst_param_io_normalise(&ins->declaration.dst, true, normaliser))
> -
>            vkd3d_shader_instruction_make_nop(ins);
>        break;
>    case VKD3DSIH_DCL_INPUT_SGV:
>    case VKD3DSIH_DCL_INPUT_SIV:
>    case VKD3DSIH_DCL_INPUT_PS_SGV:
>    case VKD3DSIH_DCL_INPUT_PS_SIV:
>    case VKD3DSIH_DCL_OUTPUT_SIV:
> -
>        keep = shader_dst_param_io_normalise(&ins->declaration.register_semantic.reg, true,
> -
>                normaliser);
> -
>        if (!shader_dst_param_io_normalise(&ins->declaration.register_semantic.reg, true, normaliser))
> -
>            vkd3d_shader_instruction_make_nop(ins);

It calls my attention the replacement from shader_instruction_init() to vkd3d_shader_instruction_make_nop(), since the latter doesn't initialize all the instruction fields to zero. Can this change the behavior?