Re: [PATCH v2 0/22] MR541: RFC: Shader cache for vkd3d

[Matteo Bruni (＠Mystral)]

On Thu Jan 11 15:23:12 2024 +0000, Stefan Dösinger wrote:
> As far as ID3D12ShaderCacheSession is concerned, both key and value
> sizes count towards the size (See
> https://gitlab.winehq.org/stefan/vkd3d/-/tree/cache-rework for tests
> which aren't included in this MR). I haven't tested the impact of
> compression and haven't checked if native compresses the storage at all.
> I think a flag for specifying a memory-only cache is a good idea. I
> (ab)used the disk_size = 0 before adding the flags field to the cache
> desc structure.

I'm sure it's just a matter of personal preference but, in my case, I'd rather not add a pointless parameter when disk_size == 0 means what you'd expect it to mean.