Re: [PATCH v21 0/9] MR3103: server: Create and use a desktop shared mapping for GetCursorPos.

[Rémi Bernon (＠rbernon)]

On Fri Mar  1 11:06:26 2024 +0000, Jinoh Kang wrote:
> Is there a reason this is not yet addressed? If you don't like the extra
> ref, I think it's better to force `(attr & OBJ_PERMANENT) != 0`, by either:
> +    assert(attr & OBJ_PERMANENT); // ensure attr is permanent
>
> or
> -                                       unsigned int attr, const struct
> security_descriptor *sd )
> +                                       const struct security_descriptor
> *sd ) // don't let caller supply attr

I didn't see why this would be necessary as the mapping is created during server init as a permanent object. There are other cases like that, such as the root directory, or the user shared mapping, though I don't really mind using a reference. Will change.