Re: [PATCH v2 0/5] MR2296: Always use the user images for the D3D12 swapchain

[Henri Verbeet (＠hverbeet)]

From patch 1/5:
> +static void test_invalid_command_queue_types(void)
> +{
> +    /* Other queue types (except DIRECT) should be added here as soon
> +     * as they are supported by vkd3d. */
> +    static const enum D3D12_COMMAND_LIST_TYPE queue_types[] =
> +    {
> +        D3D12_COMMAND_LIST_TYPE_COMPUTE,
> +        D3D12_COMMAND_LIST_TYPE_COPY,
> +    };

Why is that? We'll fail to create unimplemented command list types, but we have todo_wine for that.

It might not be a bad idea to test command list types that are supposed to succeed as well, to avoid the CreateSwapChain() call failing due to e.g. an unsupported swapchain_desc parameter.
> @@ -7721,6 +7797,8 @@ START_TEST(dxgi)
>          ID3D12Debug_Release(debug);
>      }
>
> +    test_invalid_command_queue_types();
> +
>      run_on_d3d12(test_set_fullscreen);
>      run_on_d3d12(test_resize_target);
>      run_on_d3d12(test_swapchain_resize);

Should this perhaps be a d3d12 test instead?