Re: [PATCH 0/1] MR2082: opengl32/tests: Skip the wglCopyContext test on Nvidia on Windows.

[Zhiyi Zhang (＠zhiyi)]

Zhiyi Zhang (@zhiyi) commented about dlls/opengl32/tests/opengl.c:
>  ctx2 = wglCreateContext(hdc);
>  ok(!!ctx2, "Failed to create GL context, last error %#lx.\n", GetLastError());
>
> - ret = wglCopyContext(ctx, ctx2, GL_ALL_ATTRIB_BITS);
> - todo_wine
> - ok(ret, "Failed to copy GL context, last error %#lx.\n", GetLastError());
> - if (vendor == NVIDIA && !is_wine)

I don't think we will need to check vendors often in this test. So I would prefer this condition to be (!strcmp((char *)glGetString(GL_VENDOR), "NVIDIA Corporation") && strcmp(winetest_platform, "wine")). This way you don't need to add an enum type and only change test_copy_context().

You can also add a Wine-Bug link to bug 54103.

Otherwise, this looks good to me. Thanks for looking into this.