Re: [PATCH v6 0/6] MR5601: Numpad key handling in winewayland.drv (and more generally for drivers using KBDTABLES)

[Alexandros Frantzis (＠afrantzis)]

On Mon May 20 11:46:26 2024 +0000, Rémi Bernon wrote:
> Could we pass id and lparam to send_hook_ll_message instead? Keeping the
> vkey adjustment out of it, something like https://gitlab.winehq.org/rbernon/wine/-/commit/8af64a92bc6c286e3072f4e5a906...

Yes, this is better. One aspect of the change I am unsure about, is that it moves the modifier vkey remapping later in the function, so now rawinput and KF_REPEAT handling (and also the hook) will use the non-remapped modifier vkey. Perhaps the changed behavior is in fact more correct or inconsequential (but I don't know, although modifier KF_REPEAT seems broken both ways), but given that this is a refactoring commit perhaps we should try to retain the old behavior in this commit/MR?