Re: [PATCH v2 0/9] MR209: vkd3d-shader/hlsl: Broaden resources support v2, part 3.

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/tpf.c:
> -
>                }
> -
>                if (!(name = hlsl_strdup(ctx, name_buffer->buffer)))
> -
>                {
> -
>                    sm4_free_extern_resources(extern_resources, *count);
> -
>                    *count = 0;
> -
>                    hlsl_release_string_buffer(ctx, name_buffer);
> -
>                    return NULL;
> -
>                }
> -
>                hlsl_release_string_buffer(ctx, name_buffer);
> -
> -
>                if (!(hlsl_array_reserve(ctx, (void **)&extern_resources, &capacity, *count + 1,
> -
>                        sizeof(*extern_resources))))
> -
>                {
> -
>                    sm4_free_extern_resources(extern_resources, *count);
> -
>                    *count = 0;
> -
>                    return NULL;

You're leaking `name` here. I would suggest resizing the array before allocating the name.