Elizabeth Figura (@zfigura) commented about dlls/winegstreamer/wm_reader.c:
ERR("Failed to get data pointer, hr %#lx.\n", hr); if (FAILED(hr = INSSBuffer_GetMaxLength(*sample, &capacity))) ERR("Failed to get capacity, hr %#lx.\n", hr);
- if (buffer->size > capacity)
ERR("Returned capacity %lu is less than requested capacity %u.\n", capacity, buffer->size);
Well, this check was kind of supposed to be there as a sanity check, since we're asking the application for a buffer of the relevant size. I don't mind calling it excessive and removing it, but then we don't really need the GetMaxLength() either. Either way "capacity" is kind of a weird name for the actual content size we're going to return.