On Fri Nov 18 04:11:28 2022 +0000, Mohamad Al-Jaf wrote:
Hi,
- Sure
- It looks that way, yeah. The user who reported this issue said it
only happens when they click on the "People" button in the app. They said this stub fixes the crash and haven't reported any other issue since then. But it's always possible that they just haven't stumbled upon an unimplemented call from features they haven't used. https://github.com/ValveSoftware/Proton/issues/6320 Thanks for the review!
@maljaf: A) I didn't look closely at the patch in the first run... calling SetLastError() is wrong (and will never be checked by callers). B) I have actually been working on implementing this function (among a partial implementation of another one). What I suggest is that I include your patch in the serie I'm about to send. (removing the offending SetLastError() call) It may be that the actual implementation of SymAddrIncludeInlineTrace will trigger different code paths in the mentionned game so separating stub from implementation will help on bisecting (if ever needed)