11 Nov
2022
11 Nov
'22
1:09 a.m.
On Thu Nov 10 22:39:44 2022 +0000, Francisco Casas wrote:
Maybe this could be updated to `vkd3d_unreachable();`.
Maybe, but the invariant here is "an hlsl_block resulting from an expression should never have one of these as the last instruction, because none of them have a value", which feels more like "invariant that could be violated by accident" than "invariant that can only be violated due to memory corruption". Granted, I think Henri has argued that the former should be ERR() and the latter unreachable(), i.e. there's no room for assert() anywhere...