On Fri Jul 19 17:57:05 2024 +0000, Dmitry Timoshkov wrote:
Thanks for the review. Does new version of the patch make this clearer?
No, I don't understand that change - I was taking about the line ``` size = sizeof(WORD) + sizeof(*ie_data) + len * sizeof(WCHAR) + sizeof(*next); ``` Your new change also breaks the tests.
IMHO it would be helpful to add tests for `cb`, the double termination and the `next` part. I.e. have the complete layout tested. Does some application need that or where did you get that from?
All that said, please keep in mind that I'm just hobby contributor, it's just my 2 cents.