Re: [PATCH v5 0/7] MR6360: d3dx9: Beginning of pixel format handling changes.

[Matteo Bruni (＠Mystral)]

On Mon Sep 23 19:37:31 2024 +0000, Connor McAdams wrote:
> Ah, I saw "relative error" and the function in `d3dx9_36/tests/texture.c`:
> static inline float relative_error(float expected, float got)
> {
>     return expected == 0.0f ? fabs(expected - got) : fabs(1.0f - got / expected);
> }
>
> came to mind. :) This should be fixed in the current revision, using the
> functions in `d3dx9_36/tests/math.c`.
> I've changed the format of the float constants in the calls to
> `check_pixel_float4()` to match the `%.8e` format where necessary, and
> kept the old format for things like `1.0f` and `0.0f`. Hopefully it's
> fine now.

Eh, I guess that function was named a little to well for its own good :sweat_smile:

This looks great now :slight_smile: