[PATCH 2/2] user32/tests: Handle non-null terminated strings in dde_server_wndprocA/W.

[Yuxuan Shui]

From: Yuxuan Shui

In two cases they can get a cmd string that is not null terminated:

1. A char string passed into lstrcmpW.
2. A char string that has become garbage after undergoing W -> A conversion.
---
 dlls/user32/tests/dde.c | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/dlls/user32/tests/dde.c b/dlls/user32/tests/dde.c
index 00fa72e1fa0..6f7c98abc73 100644
--- a/dlls/user32/tests/dde.c
+++ b/dlls/user32/tests/dde.c
@@ -1274,7 +1274,12 @@ static LRESULT WINAPI dde_server_wndprocA(HWND hwnd, UINT msg, WPARAM wparam, LP

if ((cmd = GlobalLock((HGLOBAL)hi)))
         {
-            ack.fAck = !lstrcmpA(cmd, exec_cmdA) || !lstrcmpW((LPCWSTR)cmd, exec_cmdW);
+            SIZE_T size;
+            BOOL maybe_w, maybe_a;
+            size = GlobalSize((HGLOBAL)hi);
+            maybe_w = (size % sizeof(WCHAR) == 0) && ((WCHAR *)cmd)[size / sizeof(WCHAR) - 1] == 0;
+            maybe_a = cmd[size - 1] == 0;
+            ack.fAck = (maybe_a && !lstrcmpA(cmd, exec_cmdA)) || (maybe_w && !lstrcmpW((LPCWSTR)cmd, exec_cmdW));

switch (step % 5)
             {
@@ -1407,7 +1412,12 @@ static LRESULT WINAPI dde_server_wndprocW(HWND hwnd, UINT msg, WPARAM wparam, LP

if ((cmd = GlobalLock((HGLOBAL)hi)))
         {
-            ack.fAck = !lstrcmpA(cmd, exec_cmdA) || !lstrcmpW((LPCWSTR)cmd, exec_cmdW);
+            SIZE_T size;
+            BOOL maybe_w, maybe_a;
+            size = GlobalSize((HGLOBAL)hi);
+            maybe_w = (size % sizeof(WCHAR) == 0) && ((WCHAR *)cmd)[size / sizeof(WCHAR) - 1] == 0;
+            maybe_a = cmd[size - 1] == 0;
+            ack.fAck = (maybe_a && !lstrcmpA(cmd, exec_cmdA)) || (maybe_w && !lstrcmpW((LPCWSTR)cmd, exec_cmdW));

switch (step % 5)
             {