On Fri Aug 26 00:36:32 2022 +0000, Davide Beatrici wrote:
What do you mean? A complex piece of software like this has rigid standards in order to prevent potential issues from arising, whether immediately or in the future. I too made a few mistakes in my merge requests, but I have always taken the time to fix them and make things look nice. This is what improving is about. Also, consider that generally the more reviewers the better:
- @julliard noticed that you changed the WinAPI definitions and
explained that you cannot do that.
- @jhol spotted the icon issue.
- I tested your changes and reported back the results.
Imagine if this merge request was accepted as it was right at the beginning: guaranteed breakage. If you deem your contribution(s) important to the project, please put on hold the MR until you have time to fix it.
OK, fair enough. I'm unemployed at the moment, so I have plenty of time, but, it's not always enjoyable. I suppose I can keep it open and work on it when I'm doing better.
I found it difficult finding implementations for COM interfaces in the code, and would like to have C++ classes instead, as I notice through public debugging symbols for DLL's on Windows 10, especially comdlg32, that developers at Microsoft are writing significant parts in C++.
I bought that up before, but it was dismissed because it may add complexity that others do not want to deal with, and, I agree that C code is more transparent.