On Tue May 9 21:20:08 2023 +0000, Zebediah Figura wrote:
Sorry for the late review; I somehow managed to miss this patch. The fact that we're trying to send twice for all socket types makes me a bit nervous, but it's probably okay. I guess there's not a particularly easy way to limit this to UDP.
We'd also need to limit it to connected UDP then which both adds complications, if not an extra server call. But I hope we might rely on the sockets not giving ECONNREFUSED for send() in any other cases, error codes are documented and breaking those in Unix kernel will probably break a lot of things anyway.